Summary
This is an email I sent to my team who had written some if statements which were dependent on the customer in use (customers could customize their UIs to some extent). I let them know that since several customers will have similar UIs, we don't need to do an if based on each customer ID, we can put some intelligence into the method so it can decide what to do based on what the UI looks like.In general, I'm not interested in testing that the UI is correct and that the test data is set up correctly - I'm interested in testing the logic, e.g. add to cart, change quantity, make a purchase. That statement is relevant here because let's say customer 1234's should be set up to use UI version A and there's a bug in UI version A. The test should fail. But if the test data has customer 1234 set up to use UI version B, the automation will happily use UI version B and may pass. But I would argue that's a data setup problem, not an automation problem, and would be a problem even if the test were run manually.
Currently in ProductFlow.java we have code that looks like this:
public void addProductToShoppingCart(
if (catalog.equals(StaticData.US_
//do one thing
} else {
//do a different thing
}
if (catalog.equals(StaticData.US_
//do one thing
} else {
//do a different thing
}
If we use lots of manufacturers, this list will get big. This method addProductToShoppingCart() does not have much intelligence in it, and theoretically the manufacturer's page could change. Something we can do instead of blindly relying on the manufacturer ID is to make the method more intelligent. The method could analyze the page, such as:
public void addProductToShoppingCart(
if (navigationLinkA.isPresent()) {
//do one thing
}
if (navigationLinkB.isPresent()) {
//do a different thing
}
if (navigationLinkA.isPresent()) {
//do one thing
}
if (navigationLinkB.isPresent()) {
//do a different thing
}
An example of this would be in the selling portal – some customers have a side navigation link with text "Part Numbers" and other have a link that has text "List by Part Number"
In fact, now that I think about it, a better solution would be to have a method called "navigateToPartList()" and put these if statements in there, then all addProductToShoppingCart() would do is call navigateToPartList()...
As I've said many times before, let's keep pushing that work farther down the road (make someone else do it), and have lots and lots of very simple, reusable methods.
As always, this is not the best solution in all cases. Using the customer ID is perfectly fine sometimes, this is just an alternative way of doing things.
